Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Missing VC runtime issue #417

Open
coderofstuff opened this issue Jan 27, 2024 · 0 comments
Open

Windows: Missing VC runtime issue #417

coderofstuff opened this issue Jan 27, 2024 · 0 comments

Comments

@coderofstuff
Copy link
Collaborator

Impact: All windows users without VCRedist installed

Users on windows encounter this upon running kaspad

Image

Workaround for now is to install VCRedist following the doc at: https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2015-2017-2019-and-2022

Possible solutions:

  • Update the GitHub action that builds kaspad in windows to ensure it builds a fully standalone app
  • Update README.md to include the VCRedist installation step
@coderofstuff coderofstuff converted this from a draft issue Jan 27, 2024
0xA001113 added a commit to spectre-project/rusty-spectre that referenced this issue Aug 1, 2024
@0xA001113
Release builds will use lto = false instead of thin:
ced5ce6 
1. It breaks x86_64-pc-windows-gnullvm target on Windows as with
   llvm optimization it is impossible to link clang libc++
   statically. The gnullvm target is needed as it will link ucrt
   instead of msvc and allow running it without VC runtime. In
   theory it should make a fix possible for:
   kaspanet/rusty-kaspa#417

2. It occasionally lead to node crashes in futures crate,
   especially when mixed with unsafe and C/C++ code. It is hard
   to reproduce, but at least with the from scratch reproduces
   the crash relatively often.
x100111010 added a commit to x100111010/rusty-kaspa that referenced this issue Sep 13, 2024
@x100111010
Release builds will use lto = false instead of thin
bc4dbb8 
* breaks x86_64-pc-windows-gnullvm target on Windows as with llvm optimization it is impossible to link clang libc++ statically. The gnullvm target is needed as it will link ucrt instead of msvc and allow running it without VC runtime. In theory it should make a fix possible for: kaspanet#417

* occasionally lead to node crashes in futures crate, especially when mixed with unsafe and C/C++ code. It is hard to reproduce, but at least with the from scratch reproduces the crash relatively often.
@x100111010 x100111010 mentioned this issue Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Rust rewrite
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coderofstuff