Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Add search pre-fill via url #4

Open
stevenhorsman opened this issue Oct 3, 2024 · 7 comments
Open

dashboard: Add search pre-fill via url #4

stevenhorsman opened this issue Oct 3, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@stevenhorsman
Copy link
Member

It would be useful, particularly when sending evidence that a test is eligible to becoming required if we could provide an optional url query parameter that would pre-fill the search box. e.g. if I want to give evidence that the run-runk tests are stable/have problems, I could link something like https://kata-containers.github.io/?search=run-runk

and it would pre-fill in the search with that string, and maybe even auto expand the results view? e.g.

image
@stevenhorsman stevenhorsman added the enhancement New feature or request label Oct 3, 2024
@sprt sprt changed the title Add search pre-fill via url dashboard: Add search pre-fill via url Oct 3, 2024
@afinn12
Copy link
Contributor

afinn12 commented Oct 9, 2024

URL search working-- example shows URL searching for "qemu" and table search looking for "coco."
(PR #15 in our repo)

Image

@stevenhorsman
Copy link
Member Author

Thanks - the demo looks great, so I look forward to seeing this get merged :)

@sprt
Copy link
Collaborator

sprt commented Oct 9, 2024

@afinn12 Can we make it so that typing in the search bar updates the URL directly? Or provide some button to click to go to that search page? I want to avoid users having to manipulate the URL directly.

@afinn12
Copy link
Contributor

afinn12 commented Oct 18, 2024

When filters are applied using the menu, the URL is immediately updated and the page is reloaded.

If "Keep URL Search Terms" is selected, the search rules from the URL will be kept in future searches.

For instance, given this search:
Image

If we add another rule:
Image

It then loads:
Image

Note that the operator changed appropriately (matches any vs. all, denoted as "and"/"or") as well.
Populating the filter menu with the rules from the URL didn't appear possible.
PR #20 in our repo

@afinn12
Copy link
Contributor

afinn12 commented Nov 1, 2024

PR #22

image

image

@afinn12
Copy link
Contributor

afinn12 commented Nov 6, 2024

PR #22

@sprt
Copy link
Collaborator

sprt commented Nov 6, 2024

Ready to review

afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 7, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 19, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 22, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Nov 22, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 3, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
afinn12 added a commit to a1icja/kata-containers.github.io that referenced this issue Dec 6, 2024
Adds an input form for searching job names. Searches are appended to the URL.

Fixes kata-containers#4

Signed-off-by: Anna Finn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants