-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate update of KEDA version in the code and yaml files during each release #580
Comments
That would be a new first step in https://github.com/kedacore/keda/blob/master/RELEASE-PROCESS.MD, is that right? |
Yes, but I'd like to see it automated. I am not that much familiar with GitHub workflows, so not sure if that's possible. But it is a matter of very simple bash script and regex. |
@ahmelsayed might know it better |
The The deploy yaml files will include a version label which currently would need to be updated manually before each release. I have found a few ways of getting this to potentially work - although unsure whether they are too hacky:
The 2nd one would mean people need to go into the |
@Cottonglow I think that a new target, like It would change the versions in |
I've created the above PR which contains a new target |
Signed-off-by: Jorge Turrado <[email protected]>
Expected Behavior
We should update a version in https://github.com/kedacore/keda/blob/master/version/version.go during each release. It is set to
1.0.0
currently, which is wrong. This value is printed in logs during the operator startup/run.Same for the versions in the yaml files under
deploy
directoryThis should be automated
Actual Behavior
Not updated
The text was updated successfully, but these errors were encountered: