Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last 3.12.0 destroy all libraries?! #4132

Closed
kelson42 opened this issue Dec 10, 2024 · 5 comments · Fixed by #4134
Closed

Last 3.12.0 destroy all libraries?! #4132

kelson42 opened this issue Dec 10, 2024 · 5 comments · Fixed by #4134
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

Claims a user:
Image

Can you please confirm this is not the case?

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz ... and please give a feedback to the user.

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Dec 11, 2024

@kelson42 I have tested this and can confirm that it is not destroying the ZIM files. However, the previously added ZIM files do not initially appear on the LocalLibraryScreen. If we refresh by swiping down, all the previously added ZIM files reappear on the library screen.

Upon further investigation, I discovered the root cause of this behavior. It seems that the file path is missing from the book entity, and our validation logic checks if the file exists before displaying it on the local library screen. If the file path is invalid or missing, the ZIM files are excluded from the list.

This issue appears to be related to an automated change in the default.json file during the implementation of #3624. Specifically, the ID of the file property was updated here due an automated change, which inadvertently caused changes to our database. Due to this, previously saved file paths are now empty, leading to these files being filtered out during validation.

@MohitMaliFtechiz ... and please give a feedback to the user.

I have updated the steps on playStore on how he can get back their existing ZIM files.

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz Can you please make a fix to fix this bad behaviour?

@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 Yes, I am placing a fix for this issue, but unfortunately it will not work for those users who have already updated their app since the database of those users has already been updated.

@kelson42
Copy link
Collaborator Author

This is a pretty dramatic error. please put counter measure to avoid this happens again. I would at least put a heavy comment in the json around that ID to explain that this Id should bot change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants