Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIM without favicon should be displayed with a default icon #966

Closed
kelson42 opened this issue Jul 26, 2023 · 9 comments
Closed

ZIM without favicon should be displayed with a default icon #966

kelson42 opened this issue Jul 26, 2023 · 9 comments
Assignees
@juuz0
Labels
enhancement good first issue
Milestone
2.4.0

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Jul 26, 2023 •
edited
Loading

In both local and remote library. Currently nothing is displayed:
image

https://github.com/kiwix/libkiwix/pull/664/files could be taken as example
@kelson42
Copy link
Collaborator Author

@juuz0 Do you think you could do that within the #946

@kelson42 kelson42 mentioned this issue Jul 26, 2023
Merged
@juuz0
Copy link
Collaborator

juuz0 commented Jul 30, 2023

@kelson42 also considering #946 (comment), you may have noticed I displayed the default icon already. But seems like some books still go under the radar, can you share one of them which doesn't show the default icon?

@kelson42 kelson42 added this to the 2.4.0 milestone Aug 3, 2023
@juuz0
Copy link
Collaborator

juuz0 commented Aug 3, 2023

@kelson42 need a zim file (whose icon doesn't show up) for testing this!

@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 3, 2023

@juuz0 I will :)

@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 3, 2023

@juuz0 Strangly I can not reproduce it. Closing for the moment, will reopen if it appears again.

@kelson42 kelson42 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
@Popolechien
Copy link
Member

@juuz0 I have one:
Documentation ubuntu française does not seem to have an icon
image

@Popolechien Popolechien reopened this Aug 4, 2023
@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 4, 2023

@Popolechien Works for me
image

I guess you don't test with latest dev version/nightly?

@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 4, 2023

But I have discovered another bug of the same kind.

@kelson42
Copy link
Collaborator Author

kelson42 commented Aug 5, 2023

@Popolechien I close again, but please reopen if you have a scenario with latest nightly.

@kelson42 kelson42 closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juuz0 juuz0

Labels
enhancement good first issue
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@kelson42 @Popolechien @juuz0