Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync releases with library users #1063

Closed
stefantalpalaru opened this issue Feb 25, 2024 · 5 comments
Closed

sync releases with library users #1063

stefantalpalaru opened this issue Feb 25, 2024 · 5 comments
Assignees
Labels
Milestone

Comments

@stefantalpalaru
Copy link

Please release kiwix-desktop and kiwix-tools at the same time you release a backwards-incompatible libkiwix. It would help us packagers not waste our time trying to figure out the compatibility.

@kelson42
Copy link
Collaborator

We are following semantic versioning, as such the backward compatibility of any new release should be clear. 13.1.0 is.... or at least: should be. Do you face any kind of problem?

@kelson42 kelson42 added this to the 13.2.0 milestone Feb 25, 2024
@kelson42 kelson42 self-assigned this Feb 25, 2024
@stefantalpalaru
Copy link
Author

Do you face any kind of problem?

Yes. Neither libkiwix-13.0.0 nor 13.1.0 work with kiwix-desktop-2.3.1 or kiwix-tools-3.6.0 - which are the latest releases.

We are following semantic versioning

That's marvellous. How about releasing software that actually works with this library? It would also help you get bug reports, if this newfangled library version is actually used by actual users.

the backward compatibility of any new release should be clear

It's not. I get a GitHub notification that a new libkiwix has been released. I bump the package version in my Gentoo overlay, then try to rebuild the packages that depend on it. That fails, so I revert back and wonder why you made me waste my time.

This has happened twice now. Do you want your software to reach end-users, or don't you?

@kelson42
Copy link
Collaborator

Do you face any kind of problem?

Yes. Neither libkiwix-13.0.0 nor 13.1.0 work with kiwix-desktop-2.3.1 or kiwix-tools-3.6.0 - which are the latest releases.

This is normal, kiwix-desktop-2.3.1 is based on libkiwix12. I have just pushed a PR to be even more explicit (than the semantic versioning) kiwix/kiwix-desktop#1044

We are following semantic versioning

That's marvellous. How about releasing software that actually works with this library? It would also help you get bug reports, if this newfangled library version is actually used by actual users.

We release when we are ready. This is, in any case, an other kind of discussion.

the backward compatibility of any new release should be clear

It's not. I get a GitHub notification that a new libkiwix has been released. I bump the package version in my Gentoo overlay, then try to rebuild the packages that depend on it. That fails, so I revert back and wonder why you made me waste my time.

Kiwix-desktop 2.3.1 should not depend on anything else than libkiwix 12. Let me know if you see anything we could do to make this more clear. kiwix/kiwix-desktop#1044 might help, but I have the feeling that the wrong assumption is more in your Gentoo package file.

@stefantalpalaru
Copy link
Author

stefantalpalaru commented Feb 25, 2024

We release when we are ready.

How can you be ready to release libkiwix, when you are not ready to release any other software that uses it?


Here's a real-life example of synced releases. The same people developing PyTorch also develop TorchVision.

Do you know how much time passed between the release of PyTorch-2.2.1 and that of TorchVision-0.17.1 (which supports the former)? Thirty-nine minutes.

@kelson42
Copy link
Collaborator

We release when we are ready.

How can you be ready to release libkiwix, when you are not ready to release any other software that uses it?

You say so, I don't. Next release to come is one of https://github.com/kiwix/java-libkiwix.

Anyway, it's not your role to decide when we have to do our releases.

It seems you have all the information needed I believe to handle your packaging properly. If any information is missing please let us know what exactly and we will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants