Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No JS fallback for kiwix-serve welcome page #615

Closed
rgaudin opened this issue Sep 13, 2021 · 11 comments · Fixed by #897
Closed

No JS fallback for kiwix-serve welcome page #615

rgaudin opened this issue Sep 13, 2021 · 11 comments · Fixed by #897
Assignees
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Sep 13, 2021

The new kiwix-serve UI is more practical but it's now impossible to use kiwix-serve without JS enabled.

There are many ways to solve this but if we consider no-js to be an edge case, we could, at least have a <noscript /> tag pointing to a separate endpoint with a static list of contents.

Screen Shot 2021-09-13 at 10 25 23

@kelson42 kelson42 added this to the 10.1.0 milestone Dec 7, 2021
@kelson42 kelson42 modified the milestones: 10.1.0, 10.2.0 Mar 24, 2022
@thavelick
Copy link
Contributor

@kelson42 - I'd be happy to work on this if there's need and no one else is tackling it. I've been considering updating kiwix-serve to do something like this regardless.

@kelson42
Copy link
Collaborator

kelson42 commented Apr 4, 2022

@thavelick Yes, you are welcome to work on this ticket.

@mgautierfr
Copy link
Member

we could, at least have a <noscript /> tag pointing to a separate endpoint with a static list of contents.

We don't have this static list now (except raw xml catalog opds feed)


Somehow related to #716, if we don't have js support, we probably want to have this list to point to the "nojs viewer" (raw content) of the zim.
Don't know where/when to handle this, but to keep in mind.

@kelson42 kelson42 modified the milestones: 10.2.0, 10.3.0 Apr 7, 2022
@kelson42 kelson42 modified the milestones: 10.2.0, 10.3.0 Apr 23, 2022
@kelson42
Copy link
Collaborator

@thavelick Any news?

@kelson42
Copy link
Collaborator

kelson42 commented Aug 11, 2022

I guess, @thavelick has abandonned the idea to propose an alternative here. We should really define what we want to build exactly.

@mgautierfr
Copy link
Member

mgautierfr commented Nov 4, 2022

We don't have this static list now (except raw xml catalog opds feed)
Don't know where/when to handle this, but to keep in mind.

I now have something in mind 🙂

The current frontpage is a js page which does specific request to opds catalog, parse the xml result and render the what is parsed dynamically.
We could simply render the catalog "odps" feed with hmtl.
The opds catalog is rendered to xml using OpdsDumper which is using mustache templates to generate xml.
If we use different templates, we should be able to generate html/css content without too much trouble on our side.
User would simply directly browse the (user friendly view of the) catalog.

We may loose some features (as the list of categories) but it should mostly works.


  • Categories are accessible throw a specific request to the opds catalog. We could also render in html those list to allow user to browse only a category
  • html template could have <form> to allow user to do a search on catalog

@veloman-yunkan
Copy link
Collaborator

We could simply render the catalog "odps" feed with hmtl.

@mgautierfr If I read that sentence literally, I think that hardly there is anyone who can do it at all 😉

@kelson42 kelson42 changed the title No JS fallback No JS fallback for kiwix-serve welcome page Nov 17, 2022
@kelson42
Copy link
Collaborator

I'm not sure where everywhere there is javascript. But could we maybe first implement #750 in C++ (instead of the js we have currently) first? This would be better from a UX as well.

@kelson42 kelson42 removed this from the 12.1.0 milestone Feb 6, 2023
@juuz0
Copy link
Collaborator

juuz0 commented Feb 12, 2023

Following mgautierfr's words above, I was able to get the same design of tiles without JS (injecting details using mustache in html file):
image

Haven't looked into how language/category filtering concretely for this. But maybe a <a> link for every language/category filtered catalog? Needs discussion here

Current draft: #897

@kelson42 kelson42 added this to the 12.2.0 milestone Feb 13, 2023
@kelson42 kelson42 removed their assignment Mar 8, 2023
@kelson42 kelson42 modified the milestones: 12.2.0, 12.1.0 Mar 8, 2023
@kelson42
Copy link
Collaborator

Bravo @juuz0 !

@juuz0
Copy link
Collaborator

juuz0 commented Mar 29, 2023

Yay, finally! 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants