Yutani: checking icon for NULL too late

[mxlgv]

Yutani doesn't check icon for NULL, probably causing applications to crash (Segmentation fault) when setting the caption in SDL like this:

SDL_WM_SetCaption("Wolfenstein 3D", NULL);

toaruos/lib/yutani.c

Line 809 in abe66fb

uint32_t length = strlen(name) + strlen(icon) + 2;

[klange]

Despite a null check later in the function, yutani_window_advertise_icon is not intended to accept NULL for the icon; clients should use yutani_window_advertise instead. The bug lies in the SDL backend: TOARU_SetCaption should be choosing yutani_window_advertise if icon is NULL. I would transfer this issue to the SDL fork, but I don't seem to have issues enabled for that repository.

[mxlgv]

In that case, this if is redundant:

toaruos/lib/yutani.c

Line 816 in abe66fb

if (icon) {

[klange]

Yeah. Maybe it should support a NULL icon... and it should probably also support a NULL name, which it fails to do in the same way... :\

[mxlgv]

Will you fix it? In my opinion, the fix is ​​quite obvious.

[klange]

I've got a fix pending on the SDL side. Still thinking about what I want to do here. Falling back to the no-icon form is likely the right choice, though I am also thinking about what should be done in both functions if the title is NULL - perhaps a signal to remove the window from the advertised window list.