Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in mmd and mcopy are silently ignored during build #309

Open
klange opened this issue Dec 31, 2024 · 0 comments
Open

Failures in mmd and mcopy are silently ignored during build #309

klange opened this issue Dec 31, 2024 · 0 comments

Comments

@klange
Copy link
Owner

klange commented Dec 31, 2024

When building for x86-64, a FAT image is created and then populated with mmd and mcopy to serve as the EFI El Torito payload.

This initial FAT image has a fixed size, haphazardly calculated from host disk usage of the source directory. This calculation is prone to underestimating the necessary size, which generally results in the attempt to add the ramdisk failing. As this is currently ignored, the build will conclude with a false success, but the resulting CD image will only have a kernel.

It would be better if this was caught so that CI builds can fail in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant