Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps fails to update vendorless project #340

Closed
cardil opened this issue Oct 12, 2023 · 1 comment · Fixed by #341
Closed

Update deps fails to update vendorless project #340

cardil opened this issue Oct 12, 2023 · 1 comment · Fixed by #341
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Oct 12, 2023

As seen in this build https://github.com/knative-extensions/knobots/actions/runs/6490025840/job/17625229242, the update-deps bot fails to update the vendorless project dependencies. See: knative/func#1964

/kind bug

The following code block doesn't open PR if there are only changes to go.mod or go.sum. Definitely, that's invalid in vendorless case.

if [ "$(basename $x)" = "go.mod" ]; then
continue
elif [ "$(basename $x)" = "go.sum" ]; then
continue

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 12, 2023
@cardil
Copy link
Contributor Author

cardil commented Oct 12, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant