Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Investigate the process of releasing serving-operator in operatorhub #157

Closed
houshengbo opened this issue Sep 3, 2019 · 8 comments
Closed

Comments

@houshengbo
Copy link

Find out the process to release serving-operator in operatorhub, and make it available there in-sync with the knative operator release.

@houshengbo houshengbo changed the title Investigation of the process of releasing serving-operator in operatorhub Investigate the process of releasing serving-operator in operatorhub Sep 3, 2019
@houshengbo
Copy link
Author

We need to have two config maps: config-logging and config-observability, to be created for the serving operator.

How can we bundle or define them in the cluster service version yaml file(metadata)? @jcrossley3

@evankanderson
Copy link
Member

Do we need the config maps to exist, or do we want to support configuring them with the operator, but allow them to be empty and use defaults in those cases?

@houshengbo
Copy link
Author

@evankanderson This is exactly what I am struggling with. We would like to take advantage of the benefit to call sharedmain.MainWithConfig, but it seems that we have to create ConfigMaps of config-logging and config-observability. We can use the default values, but they have to exist.

@markusthoemmes
Copy link
Contributor

can/should we adjust MainWithConfig to use the default if the configMap cannot be found?

@evankanderson
Copy link
Member

It looks like you could probably adjust GetLoggingConfig to handle the "does not exist" case specially; it looks like monitoring doesn't do an initial fetch of the ConfigMap, so maybe only config-logging needs to exist?

https://github.com/knative/pkg/blob/master/injection/sharedmain/main.go#L78

@aliok
Copy link
Member

aliok commented Feb 15, 2020

@houshengbo We can close this ticket I think.
We already have the operators in operator hub.
See the comment knative/eventing-operator#70 (comment) and #262

@aliok
Copy link
Member

aliok commented Mar 10, 2020

/close

@knative-prow-robot
Copy link
Contributor

@aliok: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants