feat(STONEINTG-697): remove SEB case created for successful snapshot (#…

…1125)

feat(STONEINTG-697): remove SEB case for successful snapshot

* Remove the check points for SEB created for successful snapshot
  since integration stop deloying successful snapshot to root env
* Remove SEB from integration README

Signed-off-by: Hongwei Liu <[email protected]>

tests/integration-service/README.md

@@ -17,7 +17,6 @@ Happy path testing describes tests that focus on the most common scenarios while
 - Checking that the status of integration tests were reported to the Snapshot.
 - Checking that a snapshot gets successfully marked as 'passed' after all Integration pipeline runs finished.
 - Validating the Global Candidate is updated
-- Validating the successful creation of a SnapshotEnvironmentBinding.
 - Validating the successful creation of a Release.
 
 ### E2E tests of Status Reporting of Integration tests to CheckRuns (within `status-reporting-to-pullrequest.go`):
@@ -45,7 +44,7 @@ Happy path testing describes tests that focus on the most common scenarios while
 - Validating that a new Integration PLR is created and finished.
 - Asserting that the Snapshot doesn't contain re-run label, and contains the name of re-triggered pipelinerun.
 - Asserting that a snapshot is still marked as failed.
-- Validating that no Release CRs and no SnapshotEnvironmentBinding are created in certain scenarios.
+- Validating that no Release CRs is created in certain scenarios.
 - Checking that the global candidate does not get updated unexpectedly.
 
 

tests/integration-service/integration.go

@@ -36,7 +36,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 	var pipelineRun *pipeline.PipelineRun
 	var snapshot *appstudioApi.Snapshot
 	var snapshotPush *appstudioApi.Snapshot
-	var env *appstudioApi.Environment
 	AfterEach(framework.ReportFailure(&f))
 
 	Describe("with happy path for general flow of Integration service", Ordered, func() {
@@ -57,7 +56,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 				cleanup(*f, testNamespace, applicationName, componentName)
 
 				Expect(f.AsKubeAdmin.IntegrationController.DeleteSnapshot(snapshotPush, testNamespace)).To(Succeed())
-				Expect(f.AsKubeAdmin.GitOpsController.DeleteAllEnvironmentsInASpecificNamespace(EnvironmentName, time.Minute*5)).To(Succeed())
 			}
 		})
 
@@ -138,11 +136,9 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 			})
 		})
 
-		It("creates a ReleasePlan and an environment", func() {
+		It("creates a ReleasePlan", func() {
 			_, err = f.AsKubeAdmin.ReleaseController.CreateReleasePlan(autoReleasePlan, testNamespace, applicationName, targetReleaseNamespace, "")
 			Expect(err).ShouldNot(HaveOccurred())
-			env, err = f.AsKubeAdmin.GitOpsController.CreatePocEnvironment(EnvironmentName, testNamespace)
-			Expect(err).ShouldNot(HaveOccurred())
 			testScenarios, err := f.AsKubeAdmin.IntegrationController.GetIntegrationTestScenarios(applicationName, testNamespace)
 			Expect(err).ShouldNot(HaveOccurred())
 			for _, testScenario := range *testScenarios {
@@ -186,15 +182,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 					return err
 				}, timeout, interval).Should(Succeed(), fmt.Sprintf("time out when waiting for release created for snapshot %s/%s", snapshotPush.GetNamespace(), snapshotPush.GetName()))
 			})
-
-			It("checks if an SnapshotEnvironmentBinding is created successfully", func() {
-				timeout = time.Second * 600
-				interval = time.Second * 2
-				Eventually(func() error {
-					_, err := f.AsKubeAdmin.CommonController.GetSnapshotEnvironmentBinding(applicationName, testNamespace, env)
-					return err
-				}, timeout, interval).Should(Succeed(), fmt.Sprintf("timed out when waiting for SnapshotEnvironmentBinding to be created for application %s/%s", testNamespace, applicationName))
-			})
 		})
 	})
 
@@ -208,8 +195,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 			applicationName = createApp(*f, testNamespace)
 			componentName, originalComponent = createComponent(*f, testNamespace, applicationName)
 
-			env, err = f.AsKubeAdmin.GitOpsController.CreatePocEnvironment(EnvironmentName, testNamespace)
-			Expect(err).ShouldNot(HaveOccurred())
 			integrationTestScenario, err = f.AsKubeAdmin.IntegrationController.CreateIntegrationTestScenario(applicationName, testNamespace, gitURL, revision, pathInRepoFail)
 			Expect(err).ShouldNot(HaveOccurred())
 		})
@@ -218,7 +203,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 			if !CurrentSpecReport().Failed() {
 				cleanup(*f, testNamespace, applicationName, componentName)
 
-				Expect(f.AsKubeAdmin.GitOpsController.DeleteAllEnvironmentsInASpecificNamespace(EnvironmentName, time.Minute*5)).To(Succeed())
 			}
 		})
 
@@ -348,16 +332,6 @@ var _ = framework.IntegrationServiceSuiteDescribe("Integration Service E2E tests
 				Expect(releases.Items).To(BeEmpty(), "Expected no Release CRs to be present, but found some")
 			})
 
-			It("checks no SnapshotEnvironmentBinding is created", func() {
-				seb, err := f.AsKubeAdmin.CommonController.GetSnapshotEnvironmentBinding(applicationName, testNamespace, env)
-
-				if err != nil {
-					Expect(err.Error()).To(ContainSubstring("no SnapshotEnvironmentBinding found"))
-				} else {
-					Expect(seb).To(BeNil(), "Expected no SnapshotEnvironmentBinding to be present, but found one")
-				}
-			})
-
 			It("checks if the global candidate is not updated", func() {
 				// give some time to do eventual updates in component
 				time.Sleep(60 * time.Second)