Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TargetCard to use CardHeader guidelines #1252

Closed
gitdallas opened this issue Aug 7, 2023 · 4 comments · Fixed by #2025
Closed

Update TargetCard to use CardHeader guidelines #1252

gitdallas opened this issue Aug 7, 2023 · 4 comments · Fixed by #2025
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@gitdallas
Copy link
Collaborator

Refactor the TargetCard component a bit, using PF CardHeader for header content and checkbox. Show checkbox for both checked and unchecked.

Consider using selectableActions to handle changes - this may or may not make sense in our implementation.

@dymurray dymurray moved this to 📋 Backlog in Planning Sep 15, 2023
@sjd78
Copy link
Member

sjd78 commented Jun 11, 2024

@ibolton336 -- include in work for #1950 ?

@sjd78 sjd78 added priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 11, 2024
@ibolton336 ibolton336 self-assigned this Jun 11, 2024
@ibolton336 ibolton336 moved this from 📋 Backlog to 🏗 In progress in Planning Jun 11, 2024
@ibolton336
Copy link
Member

ibolton336 commented Jun 12, 2024

Majority of this was fixed in https://github.com/konveyor/tackle2-ui/pull/1251/files. Only remaining piece is:

  • Show checkbox for both checked and unchecked.

@ibolton336
Copy link
Member

Changing the line in target-card.tsx

<Card onClick={handleCardClick} isSelectable={!!cardSelected}
to

<Card onClick={handleCardClick} isSelectable={true}

introduces a nasty PF bug where selecting a card results in triggering the onMove event via a stepChange event being fired.

Update: event.preventDefault fixed this in the card onClick handler.

@sjd78
Copy link
Member

sjd78 commented Jul 24, 2024

Yep, PR #2025 will also resolve this issue. The CardHeader.selectableActions have been aligned and the click handler moved to onChange instead of the Card.onClick.

@sjd78 sjd78 assigned sjd78 and unassigned ibolton336 Jul 24, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jul 24, 2024
@sjd78 sjd78 closed this as completed in ca232a2 Jul 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants