Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Sizing is not working correctly throughout the messages. #488

Open
bmcgonag opened this issue Jul 31, 2023 · 6 comments · May be fixed by Cretezy/flutter_linkify#136
Open

Font Sizing is not working correctly throughout the messages. #488

bmcgonag opened this issue Jul 31, 2023 · 6 comments · May be fixed by Cretezy/flutter_linkify#136

Comments

@bmcgonag
Copy link

Bug Description

The font sizing seems to try and follow the OS font settings in iOS. The issue I see is that some messages (inside the bubble) don't size the font properly. It seems a bit random, so not sure why it's happening.

OS: iOS 16.5.1 (c)
Device: iPhone 11
FluffyChat: v 1.12.0

I will add images to show what's happening. In particular notice the variation in font size per message regardless of sender / receiver.

Steps to Reproduce

  1. adjust the standard font size in iOS to something larger than normal.
    a. Settings
    b. Accessibility
    c. Display and Text Sizes
    d. Large Text = On, and in that screen adjust the font size slider to the left of center. (image attached)
  2. Create a new chat, or join an existing room on FluffyChat.
  3. Look at the variation in message sizes.

Expected Behavior

Given the enlarged font sizes, the messages will all have appropriately larger font sizes, and all messages will be consistent with their font sizing.

App Version

1.12.0

Additional Platform Information

iPhone 11, iOS 16.5.1 (c)

Additional Context

Please let me know if there is anything else I can provide. Logs, other details, testing, etc. And thank you so much for this really great app!

IMG_0417
IMG_0418
IMG_0419

@seankhl
Copy link

seankhl commented Aug 4, 2023

I'm seeing this with 1.13 on Android so I think it's a cross platform issue.

@gabrc52
Copy link
Contributor

gabrc52 commented Dec 1, 2023

This happens on Linux, Android, and iOS at least

@lolbinarycat
Copy link

i'm on android running FluffyChat 1.16.0 and am also experiencing this exact bug

@gabrc52
Copy link
Contributor

gabrc52 commented Mar 26, 2024

I am looking into this and have found the source of this bug to be in the flutter_linkify library: Cretezy/flutter_linkify#135

The last time someone brought it up, the developer of the library blamed Flutter: Cretezy/flutter_linkify#22

I will work on a PR to the upstream library.

@gabrc52 gabrc52 linked a pull request Mar 26, 2024 that will close this issue
Copy link

github-actions bot commented Aug 6, 2024

This issue is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Aug 6, 2024
@lolbinarycat
Copy link

the library this bug is from is unmaintained and needs to be forked in order for this to get fixed

@github-actions github-actions bot removed the stale The item is going to be closed soon because of inactivity label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants