Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Prow for PR merging #32

Open
jlewi opened this issue Jul 29, 2020 · 1 comment
Open

Enable Prow for PR merging #32

jlewi opened this issue Jul 29, 2020 · 1 comment

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 29, 2020

We should enable prow to review PRs .

It looks like the issue is that the ci-bots don't have permission on the repo
@jlewi jlewi mentioned this issue Jul 29, 2020
Merged
jlewi pushed a commit to jlewi/internal-acls that referenced this issue Jul 29, 2020
ci-bots need access to repository kubeflow/blog
6fc7df9 
* Related to kubeflow/blog#32
@jlewi jlewi mentioned this issue Jul 29, 2020
Merged
k8s-ci-robot pushed a commit to kubeflow/internal-acls that referenced this issue Jul 29, 2020
@jlewi
ci-bots need access to repository kubeflow/blog (#301)
0ee66d2 
* Related to kubeflow/blog#32
@chases2
Copy link

chases2 commented Aug 3, 2020 •
edited
Loading

Hello!

It looks like Prow is trying to merge things, but there isn't an OWNERS file in this repository. As a result, the approve plugin can't determine who to assign for approval.

Information about OWNERS files and how to create them can be found at https://go.k8s.io/owners. A simple YAML file, such as the example below, can do for now.

See #31 for an example of this; the link to OWNERS is currently dead.

# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- some_github_name
- another_github_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @chases2