Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure/go-autorest will soon be unsupported #2974

Open
mboersma opened this issue Jan 1, 2023 · 18 comments · May be fixed by #4780
Open

Azure/go-autorest will soon be unsupported #2974

mboersma opened this issue Jan 1, 2023 · 18 comments · May be fixed by #4780
Assignees
@mboersma
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
next

Comments

@mboersma
Copy link
Contributor

mboersma commented Jan 1, 2023

/kind deprecation
/priority important-soon

Related to the SDK v2 transition, the Azure/go-autorest library will go out of support on March 31, 2023. CAPZ should find alternatives to those modules–see here for an example of replacing to.StringPtr() and friends.
@mboersma mboersma added this to the next milestone Jan 1, 2023
@k8s-ci-robot k8s-ci-robot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 1, 2023
@dtzar
Copy link
Contributor

dtzar commented Jan 4, 2023

@mboersma - isn't this a duplicate of #2670 ?

@mboersma
Copy link
Contributor Author

mboersma commented Jan 4, 2023

@dtzar they're related but not the same: Azure/azure-sdk-for-go and Azure/go-autorest. CAPZ's direct usage of go-autorest can probably be addressed as a separate task, similarly to kubernetes-sigs/cloud-provider-azure#2983.

@mboersma mboersma mentioned this issue Jan 4, 2023
Merged
3 tasks
@CecileRobertMichon
Copy link
Contributor

@mboersma are you interested in working on this or should we mark it as help wanted?

@CecileRobertMichon
Copy link
Contributor

/milestone v1.8

@k8s-ci-robot k8s-ci-robot modified the milestones: next, v1.8 Jan 10, 2023
@mboersma
Copy link
Contributor Author

/assign

I'm psyched to work on it but since it's also intertwined with our async framework it will be more work than just replacing our to.StringPtr()-type calls.

@CecileRobertMichon
Copy link
Contributor

Should we maybe start with the to.*Ptr type calls since we'll have to do that regardless of SDK track 2 vs. ASO stuff? that can be its own PR. Then we can evaluate moving async services separately.

@mboersma mboersma mentioned this issue Jan 12, 2023
Merged
3 tasks
@CecileRobertMichon CecileRobertMichon mentioned this issue Jan 27, 2023
Merged
3 tasks
@jackfrancis jackfrancis modified the milestones: v1.8, next Mar 2, 2023
@mboersma mboersma modified the milestones: next, v1.9 Mar 9, 2023
@mboersma mboersma mentioned this issue Mar 20, 2023
Merged
3 tasks
@jackfrancis jackfrancis removed this from the v1.9 milestone Apr 6, 2023
@dtzar
Copy link
Contributor

dtzar commented May 22, 2023

@mboersma should this be attached to #3409 parent?

@mboersma
Copy link
Contributor Author

@mboersma should this be attached to #3409 parent?

Yes, good call. Although really it will probably require all of ASO to be implemented as well before go-autorest is literally not used.

@mboersma mboersma mentioned this issue May 23, 2023
Closed
@mboersma
Copy link
Contributor Author

/milestone release-1.11

@k8s-ci-robot
Copy link
Contributor

@mboersma: The provided milestone is not valid for this repository. Milestones in this repository: [next, v1.11]

Use /milestone clear to clear the milestone.

In response to this:

/milestone release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor Author

/milestone v1.11

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 13, 2023
@mboersma mboersma mentioned this issue Aug 8, 2023
Merged
4 tasks
@mboersma
Copy link
Contributor Author

/unassign

I won't be able to address this, at last for a couple weeks. If anyone else wants to pick it up, that would be 💯.

@mboersma mboersma assigned mboersma and unassigned mboersma Dec 14, 2023
@mboersma mboersma mentioned this issue Jan 9, 2024
Merged
4 tasks
@mboersma mboersma modified the milestones: v1.13, next, v1.14 Jan 17, 2024
@nojnhuh nojnhuh modified the milestones: v1.14, next Feb 29, 2024
@mboersma mboersma modified the milestones: next, v1.15 Mar 13, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Apr 4, 2024

/assign

This was referenced Apr 24, 2024
Merged
Open
@mboersma mboersma modified the milestones: v1.15, next May 6, 2024
@mboersma mboersma modified the milestones: next, v1.16 May 16, 2024
@mboersma mboersma moved this from Todo to In Progress in CAPZ Planning Jul 11, 2024
@mboersma mboersma modified the milestones: v1.16, next Jul 11, 2024
@mboersma mboersma modified the milestones: next, v1.17 Aug 8, 2024
@dtzar dtzar modified the milestones: v1.17, v1.18 Sep 20, 2024
@mboersma mboersma modified the milestones: v1.18, next Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboersma mboersma

Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
CAPZ Planning
Status: In Progress
Milestone
next
Development

Successfully merging a pull request may close this issue.

[WIP] Replace last usage of Azure/go-autorest mboersma/cluster-api-provider-azure
6 participants
@mboersma @jackfrancis @dtzar @CecileRobertMichon @nojnhuh @k8s-ci-robot