allow customizing generated webhook's name and its service's namespace and name #865

davidxia · 2023-12-01T22:39:43Z

I'm using kubebuilder which generates webhooks with these markers. The generated mutating webhook has a hardcoded name of mutating-webhook-configuration here, and the validating webhook has a hardcoded name of validating-webhook-configuration here.

The webhook's .webhooks[].clientConfig.service also have their namespace hardcoded to system and name to webhook-service, respectively.

I'd like to be able to customize these three parameters with the markers. My webhook Service might be in a different namespace and name. I might also have different webhooks that need different [Validating|Mutating]WebhookConfiguration names. It'd be nice to not have to generate these webhook YAMLs and then have to use kustomize to alter them.

Is this a feature request you're open to?

related to #490

Tasks

Give feedback

✨ Allow customizing generated webhook configuration's name #1002

approved cncf-cla: yes lgtm ok-to-test size/XL
allow customizing webhook Service's namespace and name
Options

The text was updated successfully, but these errors were encountered:

k8s-triage-robot · 2024-02-29T23:36:18Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-03-31T00:09:03Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle rotten
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

sbueringer · 2024-04-03T05:31:02Z

@davidxia sounds reasonable, if you want to open a PR for it

k8s-triage-robot · 2024-05-03T05:48:44Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue with /reopen
Mark this issue as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot · 2024-05-03T05:48:48Z

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue with /reopen

Mark this issue as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidxia · 2024-07-02T18:17:24Z

@davidxia sounds reasonable, if you want to open a PR for it

@sbueringer thanks. Can you point to the places in code where I'll need to change things?

davidxia · 2024-07-03T14:47:50Z

@camilamacedo86 don't know if you're also a maintainer for this repo, but are you able to give me some pointers to start a PR for this one too? 🙏

sbueringer · 2024-07-10T06:07:40Z

@davidxia we had a very similar PR before #824

I would expect roughly the same changes are necessary here

/reopen
/remove-lifecycle frozen
/lifecycle frozen

k8s-ci-robot · 2024-07-10T06:07:44Z

@sbueringer: Reopened this issue.

In response to this:

@davidxia we had a very similar PR before #824

I would expect roughly the same changes are necessary here

/reopen
/remove-lifecycle frozen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

davidxia · 2024-07-10T13:48:58Z

@sbueringer thanks! Just curious why the url marker doesn't show up in the webhook markers doc?

sbueringer · 2024-07-10T14:07:35Z

I would say because nobody thought about updating the docs over there :)

Although I wonder if that page is generated (but I don't know)

davidxia · 2024-07-10T14:45:46Z

I would say because nobody thought about updating the docs over there :)

Although I wonder if that page is generated (but I don't know)

Filed doc issue here.

closes kubernetes-sigs#865

closes kubernetes-sigs#865 ## example usage ``` ❯ GOBIN=(pwd)/bin go install ./cmd/* ❯ ./bin/controller-gen webhook -w Webhook +kubebuilder:webhook:admissionReviewVersions=<[]string>,failurePolicy=<string>,groups=<[]string>[,matchPolicy=<string>],mutating=<bool>,name=<string>[,path=<string>][,reinvocationPolicy=<string>],resources=<[]string>[,sideEffects=<string>][,timeoutSeconds=<int>][,url=<string>],verbs=<[]string>,versions=<[]string>[,webhookVersions=<[]string>] package specifies how a webhook should be served. +kubebuilder:webhookconfiguration:mutating=<bool>[,name=<string>] package specifies how a webhook should be served. ```

closes kubernetes-sigs#865 ## example usage ``` ❯ GOBIN=(pwd)/bin go install ./cmd/* ❯ ./bin/controller-gen webhook -w Webhook +kubebuilder:webhook:admissionReviewVersions=<[]string>,failurePolicy=<string>,groups=<[]string>[,matchPolicy=<string>],mutating=<bool>,name=<string>[,path=<string>][,reinvocationPolicy=<string>],resources=<[]string>[,sideEffects=<string>][,timeoutSeconds=<int>][,url=<string>],verbs=<[]string>,versions=<[]string>[,webhookVersions=<[]string>] package specifies how a webhook should be served. +kubebuilder:webhookconfiguration:mutating=<bool>[,name=<string>] package specifies how a webhook should be served. ``` Signed-off-by: David Xia <[email protected]>

davidxia · 2024-09-12T19:08:26Z

@sbueringer I added a task list to the issue description. We've finished the first one. For the second of allow customizing webhook Service's namespace and name, what do you think of adding an optional serviceName and serviceNamespace to the kubebuilder:webhookconfiguration marker?

Currently +kubebuilder:webhookconfiguration:mutating=<bool>[,name=<string>]

Proposed +kubebuilder:webhookconfiguration:mutating=<bool>[,name=<string>][,serviceName=<string>][,serviceNamespace=<string>]

sbueringer · 2024-09-13T06:51:33Z

Thx. Sounds good

risentveber · 2024-11-13T16:42:34Z

Also it would be nice to have a servicePort argument for mutatingwebhookconfiguration.webhooks.clientConfig.service.port

davidxia mentioned this issue Dec 2, 2023

fix operator: remove unused mutating and conversion webhook configs ray-project/kuberay#1705

Merged

4 tasks

davidxia mentioned this issue Dec 11, 2023

chore: add kuberay- name prefix to validating webhook Service ray-project/kuberay#1729

Merged

4 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 29, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 31, 2024

k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024

k8s-ci-robot reopened this Jul 10, 2024

k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024

davidxia added a commit to davidxia/controller-tools that referenced this issue Jul 10, 2024

feat: allow customizing generated webhook's name

a577c5c

closes kubernetes-sigs#865

davidxia mentioned this issue Jul 10, 2024

✨ Allow customizing generated webhook configuration's name #1002

Merged

davidxia added a commit to davidxia/controller-tools that referenced this issue Jul 11, 2024

feat: allow customizing generated webhook's name

1006456

closes kubernetes-sigs#865

This was referenced Jul 30, 2024

refactor: Remove Redundancy and duplication, check for same naming pattern on Kustomize kyma-project/lifecycle-manager#1721

Merged

Align ValidatingWebhookConfiguration and Service names kyma-project/lifecycle-manager#1744

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow customizing generated webhook's name and its service's namespace and name #865

allow customizing generated webhook's name and its service's namespace and name #865

davidxia commented Dec 1, 2023 •

edited

Loading

Tasks

k8s-triage-robot commented Feb 29, 2024

k8s-triage-robot commented Mar 31, 2024

sbueringer commented Apr 3, 2024

k8s-triage-robot commented May 3, 2024

k8s-ci-robot commented May 3, 2024

davidxia commented Jul 2, 2024

davidxia commented Jul 3, 2024

sbueringer commented Jul 10, 2024

k8s-ci-robot commented Jul 10, 2024

davidxia commented Jul 10, 2024

sbueringer commented Jul 10, 2024 •

edited

Loading

davidxia commented Jul 10, 2024

davidxia commented Sep 12, 2024

sbueringer commented Sep 13, 2024

risentveber commented Nov 13, 2024

allow customizing generated webhook's name and its service's namespace and name #865

allow customizing generated webhook's name and its service's namespace and name #865

Comments

davidxia commented Dec 1, 2023 • edited Loading

Tasks

k8s-triage-robot commented Feb 29, 2024

k8s-triage-robot commented Mar 31, 2024

sbueringer commented Apr 3, 2024

k8s-triage-robot commented May 3, 2024

k8s-ci-robot commented May 3, 2024

davidxia commented Jul 2, 2024

davidxia commented Jul 3, 2024

sbueringer commented Jul 10, 2024

k8s-ci-robot commented Jul 10, 2024

davidxia commented Jul 10, 2024

sbueringer commented Jul 10, 2024 • edited Loading

davidxia commented Jul 10, 2024

davidxia commented Sep 12, 2024

sbueringer commented Sep 13, 2024

risentveber commented Nov 13, 2024

davidxia commented Dec 1, 2023 •

edited

Loading

sbueringer commented Jul 10, 2024 •

edited

Loading