Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Budgets in HTTPRouteRetry #3388

Open
rajatsharma94 opened this issue Oct 10, 2024 · 5 comments · May be fixed by #3488
Open

Retry Budgets in HTTPRouteRetry #3388

rajatsharma94 opened this issue Oct 10, 2024 · 5 comments · May be fixed by #3488
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@rajatsharma94
Copy link

What would you like to be added:

I would like to be able to configure retry budgets in HTTPRouteRetry

Why this is needed:

While #1731 implements HTTPRouteRetry, we still lack the capability to set the retries using a percentage. This was part of #1731 initially but was dropped out of scope later on.

Implementations like Linkerd rely solely on this percentage based budget to implement the retry functionality.

@rajatsharma94 rajatsharma94 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2024
@mikemorris
Copy link
Contributor

/assign @ericdbishop

@k8s-ci-robot
Copy link
Contributor

@mikemorris: GitHub didn't allow me to assign the following users: ericdbishop.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ericdbishop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mikemorris
Copy link
Contributor

/assign

@ericdbishop
Copy link

Commenting so i can be assigned this.

@mikemorris
Copy link
Contributor

mikemorris commented Nov 26, 2024

/assign @ericdbishop

This issue has been included in the planned scope for the Gateway API v1.3 release - I'm planning to support @ericdbishop through the GEP process to help move this forward (and would welcome additional help from @rajatsharma94 @kflynn or others interested in this functionality too)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants