-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python SDK: Install Python and Java from source rather than using package manager #190
Comments
/good-first-issue |
@danielvegamyhre: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
Rather than building from source, should we just have all this run in a container? Building from source is going unlease a maintenance headache as you will have to support issues related to builds on all different kinds of Linux OSes. I look forward to this issue as my dev environment is quite flaky now as I don't have apt. |
Just an update on this issue, I had to change the python sdk to use a container. @danielvegamyhre and I think the way forward should be using containers to generate these clients rather than relying on package managers or building from source. so the client go one should ideally also use a container to generate sdk |
@chansuke are you still working on this? I will assign it to myself if not. |
@jedwins1998 I'm not working.You can take it🫡 |
/assign |
/assign |
The end of life for openjdk-11 will be October 2024 and openjdk-17 is superseded on openjdk's website https://jdk.java.net/17/. Will grabbing openjdk-17 from other vendors such as Microsoft, Oracle.. be fine? |
Yes that should be fine. |
Also just a quick question since python sdk is being generated from openapi-generator-cli I'm assuming that we don't need to update that to install from source anymore, just want to double check if that is the correct |
@epicseven-cup see this comment thread above, I think it would be better for portability if wecontainerize SDK code gen rather than building from source as the issue description states. |
What would you like to be added:
We should install Python and Java from source rather than using an environment specific package manager (apt).
Why is this needed:
To improve the developer experience SDK generation (ran by
make generate
) and testing scripts (ran bymake test
) more platform agnostic.The text was updated successfully, but these errors were encountered: