Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python SDK: Install Python and Java from source rather than using package manager #190

Open
danielvegamyhre opened this issue Jun 15, 2023 · 13 comments · May be fixed by #681
Open

Python SDK: Install Python and Java from source rather than using package manager #190

danielvegamyhre opened this issue Jun 15, 2023 · 13 comments · May be fixed by #681
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Jun 15, 2023

What would you like to be added:
We should install Python and Java from source rather than using an environment specific package manager (apt).

Why is this needed:
To improve the developer experience SDK generation (ran by make generate) and testing scripts (ran by make test ) more platform agnostic.

@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 15, 2023
@danielvegamyhre
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@danielvegamyhre:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 15, 2023
@chansuke
Copy link
Member

/assign

@kannon92
Copy link
Contributor

Rather than building from source, should we just have all this run in a container? Building from source is going unlease a maintenance headache as you will have to support issues related to builds on all different kinds of Linux OSes.

I look forward to this issue as my dev environment is quite flaky now as I don't have apt.

@kannon92
Copy link
Contributor

kannon92 commented Jul 1, 2023

Just an update on this issue, I had to change the python sdk to use a container. @danielvegamyhre and I think the way forward should be using containers to generate these clients rather than relying on package managers or building from source.

so the client go one should ideally also use a container to generate sdk

@jedwins1998
Copy link
Contributor

jedwins1998 commented Apr 2, 2024

@chansuke are you still working on this? I will assign it to myself if not.

@chansuke
Copy link
Member

chansuke commented Apr 3, 2024

@jedwins1998 I'm not working.You can take it🫡

@jedwins1998
Copy link
Contributor

/assign

@epicseven-cup
Copy link

/assign

@epicseven-cup
Copy link

The end of life for openjdk-11 will be October 2024 and openjdk-17 is superseded on openjdk's website https://jdk.java.net/17/.

Will grabbing openjdk-17 from other vendors such as Microsoft, Oracle.. be fine?

@danielvegamyhre
Copy link
Contributor Author

The end of life for openjdk-11 will be October 2024 and openjdk-17 is superseded on openjdk's website https://jdk.java.net/17/.

Will grabbing openjdk-17 from other vendors such as Microsoft, Oracle.. be fine?

Yes that should be fine.

@epicseven-cup
Copy link

epicseven-cup commented Sep 29, 2024

Also just a quick question since python sdk is being generated from openapi-generator-cli I'm assuming that we don't need to update that to install from source anymore, just want to double check if that is the correct

@danielvegamyhre
Copy link
Contributor Author

Just an update on this issue, I had to change the python sdk to use a container. @danielvegamyhre and I think the way forward should be using containers to generate these clients rather than relying on package managers or building from source.

so the client go one should ideally also use a container to generate sdk

@epicseven-cup see this comment thread above, I think it would be better for portability if wecontainerize SDK code gen rather than building from source as the issue description states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
6 participants