Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi release github action for python sdk #736

Open
asaiacai opened this issue Dec 20, 2024 · 4 comments
Open

pypi release github action for python sdk #736

asaiacai opened this issue Dec 20, 2024 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@asaiacai
Copy link

What would you like to be added:

Nightly builds of the python sdk to pypi

Why is this needed:

It'd be easier to install from pypi.

@kannon92
Copy link
Contributor

To be clear, installing of the python-sdk would not mean that jobset is "installed" on your cluster. The SDK provides bindings to create jobsets from python. But if a cluster does not have the CRD then the sdk would fail.

I think we could consider pypi wheels on a release of jobset. I don't think nightly builds would be worth the squeeze at the moment.

cc @ahg-g @danielvegamyhre

@asaiacai
Copy link
Author

i see. yeah nightly might be early, but i agree that pypi release wheels would already be helpful in this situation.

@asaiacai asaiacai changed the title pypi nightly github action for python sdk pypi release github action for python sdk Dec 20, 2024
@danielvegamyhre
Copy link
Contributor

To be clear, installing of the python-sdk would not mean that jobset is "installed" on your cluster. The SDK provides bindings to create jobsets from python. But if a cluster does not have the CRD then the sdk would fail.

I think we could consider pypi wheels on a release of jobset. I don't think nightly builds would be worth the squeeze at the moment.

cc @ahg-g @danielvegamyhre

I agree this would be great. Adding some help wanted / good first issues labels on this.

@danielvegamyhre danielvegamyhre added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 20, 2024
@kannon92
Copy link
Contributor

Tbh I don’t really know much about our python support for wheels. There is a kubernetes client in Python that lives in PyPi. We could look to see how they publish wheels to PyPi and follow that approach. We don’t really use GitHub actions for releases so it would most likely be a prow job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants