Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix delete workspace with deleting project on workspace baseinfo page #4384

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

fuchunlan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Links #https://github.com/kubesphere/project/issues/4803

Special notes for reviewers


Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc


@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Dec 24, 2024
@fuchunlan
Copy link
Contributor Author

/cherrypick master

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 24, 2024
@ks-ci-bot
Copy link
Collaborator

@fuchunlan: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@donniean
Copy link
Contributor

/test pull-console-build

2 similar comments
@donniean
Copy link
Contributor

/test pull-console-build

@donniean
Copy link
Contributor

/test pull-console-build

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, fuchunlan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@donniean
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d6118504771fc8cae97ef80c8ffd1429c685a705

@ks-ci-bot ks-ci-bot merged commit 0d984a3 into kubesphere:release-4.1 Dec 24, 2024
3 checks passed
@donniean
Copy link
Contributor

/cherry-pick master

@ks-ci-bot
Copy link
Collaborator

@fuchunlan: new pull request created: #4389

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request could not be created: failed to create pull request against kubesphere/console#master from head ks-ci-bot:cherry-pick-4384-to-master: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ks-ci-bot:cherry-pick-4384-to-master."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants