Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add name rules when create yaml app #4387

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix: add name rules when create yaml app #4387

merged 1 commit into from
Dec 24, 2024

Conversation

ROOMrepair
Copy link
Contributor

@ROOMrepair ROOMrepair commented Dec 24, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it

Which issue(s) this PR fixes

Links #https://github.com/kubesphere/project/issues/4869

Special notes for reviewers

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none and removed do-not-merge/release-note-label-needed labels Dec 24, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donniean, ROOMrepair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2024
@donniean
Copy link
Contributor

/cherry-pick master

@donniean
Copy link
Contributor

/lgtm

@ks-ci-bot
Copy link
Collaborator

@donniean: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 2adbab8ef72d7c560ed4e3b6fe6584b3438285bc

@ks-ci-bot ks-ci-bot merged commit 868e9e3 into kubesphere:release-4.1 Dec 24, 2024
3 checks passed
@ks-ci-bot
Copy link
Collaborator

@donniean: new pull request created: #4388

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donniean donniean donniean approved these changes

Assignees

@donniean donniean

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ROOMrepair @ks-ci-bot @donniean