Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of custom for resource business_unit_company and business_unit_division #541

Open
gasttor opened this issue Nov 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@gasttor
Copy link
Contributor

gasttor commented Nov 28, 2024

Currently it is not possible to use custom for the resources commercetools_business_unit_company as well as commercetools_business_unit_division

Would it be possible to add it, so that that block like below can be used?

custom {
    type_id = commercetools_type.test.id
    fields = {
	"my-field" = "bar"
    }
}
@gasttor gasttor added enhancement New feature or request triage Needs triage labels Nov 28, 2024
@demeyerthom
Copy link
Member

Hi @gasttor yeah that should not be a problem! I will see if I can free up some time to pick it up.

If you are in a hurry feel free to make a PR adding this feature, I am always happy to review it! We probably want to add something along the lines of commercetools/custom_fields.go, but as part of the internal namespace instead

@demeyerthom demeyerthom removed the triage Needs triage label Nov 29, 2024
@gasttor
Copy link
Contributor Author

gasttor commented Dec 2, 2024

Hi @demeyerthom,
I can have a look at this. But to get familiar with the code I started with an easier fix. I just provided a PR for issue 522. Maybe we can start with this :)

@demeyerthom demeyerthom self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants