Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to use a more recent Elasticsearch client version #58

Open
miguelgrinberg opened this issue Dec 11, 2024 · 0 comments

Comments

@miguelgrinberg
Copy link
Collaborator

The unit tests are currently designed for Elasticsearch clients up to 8.15.x. The 8.16 client introduced some changes in how hybrid search requests are made, using a retriever query instead of the knn query in older clients. The unit tests have assertions that depend on the requests issued by the 8.15 and older clients. These need to be updated, or better yet, the tests should not depend on what requests the low-level issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant