Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-chain Cryptopunks data URI encoding #18

Open
bpierre opened this issue Aug 22, 2021 · 0 comments
Open

On-chain Cryptopunks data URI encoding #18

bpierre opened this issue Aug 22, 2021 · 0 comments

Comments

@bpierre
Copy link

bpierre commented Aug 22, 2021

On the new contract generating the Cryptopunks images, the SVG returned as a data URI is not URI encoded, which means it can’t be used directly (e.g. on <img src="">) without processing it.

This is how useNft() does it for example:

https://github.com/spectrexyz/use-nft/blob/e136d484c2a84bf99947d1cc1e15fb33f99bf140/src/fetchers/shared/cryptopunks.ts#L22-L28

It would be ideal if punkImageSvg() would return a string that is already URI encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@bpierre and others