-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTK4 Flatpaks don't use adw-gtk3 #235
GTK4 Flatpaks don't use adw-gtk3 #235
Comments
Any specific apps? |
Transmission, for example. |
Looking at @dusansimic Is this something that can be fixed? Note that the GTK4 theme also import CSS files from a different directory. adw-gtk3/gtk/src/adw-gtk3/gtk-4.0/gtk.css Line 38 in edb1107
|
Yes. I haven't realized that GTK4 support has been added. I'll modify the flatpak manifest so it includes the GTK4 theme. |
@julianfairfax could you try out patched versions of flatpak packages? You can download them using the following commands. $ flatpak install --user https://dl.flathub.org/build-repo/34773/org.gtk.Gtk3theme.adw-gtk3.flatpakref
$ flatpak install --user https://dl.flathub.org/build-repo/34772/org.gtk.Gtk3theme.adw-gtk3-dark.flatpakref |
I can do that earliest on Wednesday, so maybe best to have someone else test before then? |
This did not work on my end. Transmission from flathub is still not using the GTK4 theme. I also couldn't find the new install location for the updated flatpaks. Usually it's in |
Same for me |
It's installed into the current user (that's what's the |
The directory layout should be: |
@dusansimic any update on this? |
Okay, so I've reached out to the flatpak community through their channels and found out that gtk4 themes are not supported through flatpak packages like What users can however do is do just what is described in the gtk4.md, override the theme directory with flatpak permissions. This would however require installing the gtk4 theme locally (for example in the |
The runtime needs to create a separate extension point for it flatpak/flatpak#4605, only Gtk3 themes have extension now Then you can create a separate package like
I think it will be supported, just the work needs to be done. Pop, Yaru etc. are also interested in this. Edit. Follow https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/697, https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1620 |
FDO has been pushing back against us on this. I haven't even asked on GNOME's gitlab yet because I do not believe they will be sympathetic to the cause of theming. However, if FDO continues to refuse to integrate GTK4 until it meets whatever criteria GTK3 met to justify its inclusion, GNOME may be the only folks who can do it. I brought up a question on FDO's tracker: the existence of GTK3 theme extension points was mainly only necessary because every GTK3 version kept breaking the way themes worked until around 3.18 or 3.20. Icon themes are actually just passed directly into the sandbox, exposed as So I want to ask: what's version churn like on GTK4 theme compatibility? Because it's possible that it may be better to take the same approach as is currently taken with icons and just pass them into the sandbox as-is. Do minor-versioned theme directories (gtk-3.18, gtk-3.20, gtk-3.22, etc) still exist in GTK4 in case they decide to go and break everything again? |
I have been researching about this issue recently, and to my surprise it works, on Fedora Silverblue system, when I put adw-gtk3 theme folders in /var/home/(myusername)/.themes, in other locations it just doesn't work, for me at least. I hope this info is helpful in some way. |
Thanks! This worked for me. I wonder why it has to go there though? I'd prefer not to have the folder in my home directory really... but I'll go with this for now since it works. |
Prerequisites
Checklist to make sure the issue is not on your end
~/.local/share/themes
or/usr/share/themes
or~/.themes
~/.config/gtk-3.0/gtk.css
does not exist. (If it does, backup and remove it.)gnome-tweaks
AND set the appearance to dark ingnome-control-center
org.gtk.Gtk3theme.adw-gtk3
andorg.gtk.Gtk3theme.adw-gtk3-dark
Description
I know, but, it is my understanding that this should work? I don't know what's going on. I have the Flatpak theme installed.
OS and version [e.g Fedora 37]
Debian Trixie
Adw-gtk3 version. Also specify your installation source. [e.g tar.xz, AUR, git main branch]
4.8
GNOME version
44.2
Application name and version (If the issue is with an app.)
No response
The text was updated successfully, but these errors were encountered: