Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Don't select inactive channel peers as part of the last hop of a blinded route #9339

Open
ziggie1984 opened this issue Dec 8, 2024 · 3 comments

Comments

@ziggie1984
Copy link
Collaborator

When creating a blinded path invoice, we should not select peers/channels which do not have an active channel with the receiving node. When creating the blinded route, we should query the switch (as it is already done for the payment pathfinding) and avoid channels which are inactive.

@ziggie1984
Copy link
Collaborator Author

Addition:

  • Also do not include channels which are disabled.

@yyforyongyu
Copy link
Member

I think it's the router's job to decide whether an edge is active or not, and it should not be leaked into the switch. #8835 may be related.

@ziggie1984
Copy link
Collaborator Author

I think it's the router's job to decide whether an edge is active or not, and it should not be leaked into the switch. #8835 may be related.

I was referring to the bandwidthManager which makes it possible for the channel router to make assumption of the balance distribution by asking the switch. So I think it is the other way around the switch is leaked into the channelrouter, which seems ok given that the router is the layer 3 of the stack ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants