Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise the timeout parameter in actions #133

Open
oscherler opened this issue Nov 28, 2017 · 0 comments
Open

Generalise the timeout parameter in actions #133

oscherler opened this issue Nov 28, 2017 · 0 comments

Comments

@oscherler
Copy link

I have a pre-release action that takes some time (ant on a GWT project), and it sometimes triggers the Symfony Process component’s 60 s timeout. I’m thinking of making a PR to add a timeout option to the command action, but before I start working, I should ask:

  • Is this desired?
  • Should I add it to the composer-stability-check and composer-json-check prerequisites as well? They use the executeCommandInProcess method of BaseAction, that uses the Process component;
  • Should I also set the default timeout to a higher value, to avoid having to set it on all potential long-running commands in the rmt.yml file?
  • Would a global timeout option at the root level of the rmt.yml file be necessary?

Thanks for making RMT, I love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant