Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU] Emptying trash: Many unnecessary Email/query + Email/get requests #3372

Open
chibenwa opened this issue Dec 20, 2024 · 4 comments
Open
Assignees
Labels

Comments

@chibenwa
Copy link
Member

Description

WHEN I empty my trash with 180 messages in it

THEN Tmail...

  • Performs an initial email/query + email/get operation to catch the emails
  • Then Email/set destroy a batch of mails
  • Then resyncs too much on websocket notifications (not the issue here)
  • Then issue hundreds of Email/query + Email/get that actually returns empty payload <= that 's the issue here.

Screenshot from 2024-12-20 11-32-17

Why are those requests made?

Expected result

Avoid needless requests when emptying trash...

@chibenwa
Copy link
Member Author

(is it possible that resynch on an empty mailbox triggers an aggressive Email/query+get ) ?

If so having a debounce on this behaviour would be nice!

@hoangdat
Copy link
Member

  • Replace Email/query + Email/get + Email/set with Email/query + Email/set

@chibenwa
Copy link
Member Author

Replace Email/query + Email/get + Email/set with Email/query + Email/set

+1 but notDestroyed setError results will need fine tuning...

If not found treat the message as deleted, otherwize do considère deletion failed.

@chibenwa
Copy link
Member Author

(this multiple entry issue is temporary and will disapear with multiple composer so is temporary.
A cache that handles not gracefully multiple entries is better than no cache at all...
Si please do not over engineer the multiple cache entry issue...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants