Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests from IPv6 IP addresses not logged #20

Closed
cjh79 opened this issue Jun 19, 2020 · 1 comment
Closed

Requests from IPv6 IP addresses not logged #20

cjh79 opened this issue Jun 19, 2020 · 1 comment

Comments

@cjh79
Copy link
Contributor

cjh79 commented Jun 19, 2020

Problem is the fix to #12, which breaks logging on any IPv6 addresses since they are colon-separated hex numbers and results in an exception like (on postgres):

psycopg2.errors.InvalidTextRepresentation: invalid input syntax for type inet: "2604"

I am working on a PR to fix this which I should have ready shortly. I am filing this issue in case someone googles that exception. And unfortunately this means that since that fix, anyone using this has been missing out on logs from any IPv6 addresses...
cjh79 added a commit to cjh79/drf-api-tracking that referenced this issue Jun 19, 2020
@cjh79
Fix broken logging for requests from IPv6 addresses.
d8cef50 
lingster#20
@cjh79 cjh79 mentioned this issue Jun 19, 2020
Merged
@lingster
Copy link
Owner

PR has been merged and available in 1.7.5 release.

@cjh79 cjh79 closed this as completed Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lingster @cjh79