Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the display issue #175

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

pengfeixx
Copy link
Contributor

Fixed the display issue

Bug: https://pms.uniontech.com/bug-view-277249.html, https://pms.uniontech.com/bug-view-277813.html

Log: Fixed the display issue

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. utils.cpp文件中,formatMillisecond函数的返回值格式从mm:ss更改为hh:mm:ss,这可能会导致与预期不符的行为,特别是当curSecond大于等于3600时。建议确认这一更改是否符合业务逻辑需求。

  2. FolderListView.qmlItemListView.qml文件中,onEntered信号处理函数中添加了对folderNameLabelnoteNameLabel宽度的检查,这可能会影响性能,因为每次鼠标进入时都会进行布局计算。建议考虑使用更高效的方式来处理这个问题,例如使用RequestAnimationFrame

  3. RecordingView.qml文件中,time属性的默认值从"00:00"更改为"00:00:00",这可能会影响与旧版本软件的兼容性。建议确认这一更改是否符合所有使用场景。

  4. RecordingView.qml文件中,Rectangle元素backRectanglegradient属性使用了DTK.themeType,这可能会导致在不同主题之间切换时出现闪烁。建议使用更稳定的主题切换机制。

  5. WebEngineView.qml文件中,noSearchRectheight属性从42更改为70,这可能会影响布局。建议确认这一更改是否符合设计需求。

  6. bootstrapCssReset.css文件中,.note-color-back .note-color-palette .note-color-btn::before伪元素的top属性从50%更改为115%,这可能会导致布局问题。建议确认这一更改是否符合设计需求。

  7. dark.css文件中,.note-color-back .note-color-palette .note-color-row:first-child .note-color-btn:first-child::before伪元素的background-color属性从#00000040更改为rgba(255, 255, 255, 0.2),这可能会导致颜色不一致。建议确认这一更改是否符合设计需求。

  8. index.js文件中,airPopoverRightMargin的值从15更改为35,这可能会影响布局。建议确认这一更改是否符合设计需求。

  9. summernote_v9_2.js文件中,var curBackColors = isDarkTheme ? this.options.simpleDarkBackColors这一行代码缺少分号,可能会导致语法错误。建议添加分号。

以上是针对代码更改的审查意见,希望能够帮助到您。

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit 7afa5a1 into linuxdeepin:develop/snipe Jan 2, 2025
17 checks passed
@pengfeixx pengfeixx deleted the bugfix branch January 2, 2025 10:50
@rb-union
Copy link
Contributor

rb-union commented Jan 2, 2025

在js文件中的135%也需要和css中同步修改为115%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants