Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noTaintMaster in kubeadm.conf #72

Open
ijc opened this issue Apr 9, 2018 · 1 comment
Open

Use noTaintMaster in kubeadm.conf #72

ijc opened this issue Apr 9, 2018 · 1 comment

Comments

@ijc
Copy link
Contributor

ijc commented Apr 9, 2018

With the switch to v1.10 in #70 we can now make use of kubernetes/kubernetes#55479 and set noTaintMaster: true in kubeadm.conf instead of untainting after initialisation.

Perhaps also depends on #71?

@ijc
Copy link
Contributor Author

ijc commented Jun 15, 2018

This has changed in kubernetes/kubernetes#64210 (will be in v1.12 AFAICT). A comment in there explains:

+	// Taints specifies the taints the Node API object should be registered with. If this field is unset, i.e. nil, in the `kubeadm init` process
+	// it will be defaulted to []v1.Taint{'node-role.kubernetes.io/master=""'}. If you don't want to taint your master node, set this field to an
+	// empty slice, i.e. `taints: {}` in the YAML file. This field is solely used for Node registration.
+	Taints []v1.Taint

Also related: kubernetes/kubernetes#65068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant