[Import Users from .csv files] Users with certain characters in password, firstname, lastname couldn't be imported - Empty or invalid data provided

[nrmn4usm]

First Name containing certain characters
First name containing (.) (@) (') (/). Users with these characters will not be imported.

To Reproduce
Use the following example:
[email protected],76898,[email protected],Jane@Janet, Doe

Expected behavior
Was not a problem before. In fact, last time, if any users with the first letter as capital letter (first name or last name), no problem too!

When I says last time, I checked, it was when the validation.php file content is like in the attachment. Extracted from our running server.

Error Message
Empty or invalid data provided

Desktop (please complete the following information):

• OS: Windows 11
• Your Browser: Chrome
• daloRADIUS Version: [e.g. "cloned the master branch today on commit hash 566 by @kraman2681"]
• FreeRADIUS Version: 3
• Installed using the install.sh - installation was fine on Ubuntu 24.04.1 LTS (x86-64) - thanks for making this @filippolauria

validation.zip

Edit:
For the password field, the problem only occurs when using Import Users. Example of password is like "0123/29". However, if I want to add the user manually, such password could be accepted.

Problem only with the first name field. I tested this for the second time on a freshly installed Ubuntu 24.04.1 LTS (x86-64). It seems that the regex in these field doesn't like (/) - in my country, names with this kind of character is normal, (@) - people with alias, or even dot (.) is also common. Same thing for (-), as well as (') and (`). As you noticed, I highlight only on the first name field. This is because, I didn't test with the last name. In my setup, I use the last name as their type (e.g. "- staff", "- student" etc.); weirdly, the (-) in the last name (for my case) doesn't give any issue.

I have more than thousand users. Currently, I am using the old Daloradius without this issue. It runs without any problem on Raspberry Pi. Now I want to use the latest version of Daloradius which is better (except for the issue that I pointed out here) on a Proxmox Ubuntu VM - a much better hardware. Editing each user with "bad" first name and adding users with "bad" password manually would be a non-smart move.

[nrmn4usm]

I retried (again with a freshly installed Ubuntu) for the password, using the Import Users, it looks like (@) is fine. It hates (/), ('), (`).

[nrmn4usm]

Sample errors.csv

Attached is an example of .csv file to be imported through Import Users.

Here is the content:
[email protected],985471254789,[email protected],John Doe, - STAFF
[email protected],123456789528,[email protected],Mohd. Zaid, - STAFF
[email protected],012547965327,[email protected],Jane Doe, - STAFF
[email protected],489632101458,[email protected],Jack White, - STAFF
[email protected],026979502549,[email protected],Kevin@Calvin, - STAFF
[email protected],7778896654125,[email protected],Kermit Paulie, - STAFF
[email protected],12345/215871,[email protected],Julia Andy, - STAFF

Users from Line 1, 3, 4 and 6 can be imported without any issue.

Users from Line 2, 5 and 7 are omitted.
Users from Line 2 and 5 are omitted due to the (.) and (@). Of course if I remove the (.) and (@), they can be imported w/o any issue.
User from line 7 are omitted due to the password (/). If I remove the (/), it can be imported.

However, the user from line 7 can be added through the menu New User even with (/) without any issue.

[nrmn4usm]

For the problems described above, I decided to clean-up my users' first name. Its just Excel. But for the password field problem, I couldn't add my users manually. There are hundreds of them. And they are my current users, they are already using the accounts (username and password); not new users.

For the clear-text password problem when using "Import Users" feature (.csv files), besides the character (/), the current version also doesn't accept (-). Example: [email protected],12-345/215871,[email protected],Julia Andy, - STAFF

However, when using "New User" or "New User - Quick Add", when I enter the details manually, it is fine, without any problem - even if the password contains (-) and/or (/).

As I said, I couldn't add my users with the clear-text password with (-) and (/) manually. There are hundreds of them. And I think this is my 5th/6th attempt of installing Daloradius, each were on a freshly installed Ubuntu 24.04.1 LTS.

Really need your help. Please.

@filippolauria , @kraman2681 @lirantal

[nrmn4usm]

Hi,

(If there is still people who still monitor this GitHub issues)

Regarding the issue that I pointed out since Sept. 25, 2024, regarding the .csv file that we use to import users, I found that the 2 fields from the .csv that gave me problem in importing users. Out of the username,password,email,firstname,lastname fields, the field:

1. password

Whenever there is "/" inside the field, the "Import Users" process will surely fail. Weirdly, if I add a user manually (using "New User"), the same user can be imported without any issue.

I recently found that the character "-" will not give such issue; only "/".

2. firstname

Whenever there is "@" or "." inside the field, the "Import Users" process will surely fail. For this field, I never import the problematic users manually. I went for editting it manually from Excel since no respond has been received. No big deal. However, a bug is still a bug. I hope that someone could correct this issue.

I am not sure about the lastname field. It could have the same bugs. I use this field for other purpose.

Besides numerous attempts in re-trying/re-installing the Daloradius on Ubuntu, I also recently tried on Debian. Of course the latest version Bookworm. Same bugs happened.