release 1.1?

[carrot-garden]

Laird, hi;

I am curious if you can cut out 1.1 release?

thanks;

Andrei.

[ljnelson]

Haven't looked at this in a while; let me take a look. Thanks for the
nudge!

Best,
Laird

On Sun, Jul 8, 2012 at 6:31 AM, Andrei Pozolotin <
[email protected]

wrote:

Laird, hi;

I am curious if you can cut out 1.1 release?

thanks;

Andrei.

---

Reply to this email directly or view it on GitHub:
#1

http://about.me/lairdnelson

[carrot-garden]

cool!

FYI:

current version 1.0 seems to forget to kill spawned instances when build fails between

pre-integration-test

and

post-integration-test

for this case

                <plugin>
                    <groupId>com.edugility</groupId>
                    <artifactId>h2-maven-plugin</artifactId>
                    <version>1.0</version>
                    <configuration>
                        <baseDirectory>target/h2/it</baseDirectory>
                        <port>8888</port>
                        <!-- <services> -->
                        <!-- <service> -->
                        <!-- <id>tcp</id> -->
                        <!-- </service> -->
                        <!-- <service> -->
                        <!-- <id>web</id> -->
                        <!-- </service> -->
                        <!-- </services> -->
                    </configuration>
                    <executions>
                        <execution>
                            <id>h2-start</id>
                            <phase>pre-integration-test</phase>
                            <goals>
                                <goal>spawn</goal>
                            </goals>
                        </execution>
                        <execution>
                            <id>h2-finish</id>
                            <phase>post-integration-test</phase>
                            <goals>
                                <goal>stop</goal>
                            </goals>
                        </execution>
                    </executions>
                </plugin>

[ljnelson]

I'm not sure there's much I can do in that case. Each plugin invocation in
those phases is separate from the other. Did you have a solution in mind?

Best,
Laird

On Sun, Jul 8, 2012 at 10:56 AM, Andrei Pozolotin <
[email protected]

wrote:

cool!

FYI:

current version 1.0 seems to forget to kill spawned instances when build
fails between

pre-integration-test

and

post-integration-test

for this case

                                    <plugin>

com.edugility

h2-maven-plugin
1.0

target/h2/it
8888

h2-start

pre-integration-test

spawn

h2-finish

post-integration-test

stop

---

Reply to this email directly or view it on GitHub:
#1 (comment)

http://about.me/lairdnelson

[carrot-garden]

ExecutionListener ?

http://maven.apache.org/ref/3.0.4//maven-core/apidocs/org/apache/maven/execution/ExecutionListener.html

[ljnelson]

Interesting; OK; I'm not sure what the lifecycle is defined to be for a
plugin instance. I.e. is one instance created for the first phase and a
second instance created for the second phase? Or is one instance created
for use by all phases? Regardless, I'll look into this.

Thanks,
Laird

On Sun, Jul 8, 2012 at 3:56 PM, Andrei Pozolotin <
[email protected]

wrote:

ExecutionListener ?

http://maven.apache.org/ref/3.0.4//maven-core/apidocs/org/apache/maven/execution/ExecutionListener.html

---

Reply to this email directly or view it on GitHub:
#1 (comment)

http://about.me/lairdnelson

[carrot-garden]

here is one customer where this is critical:
https://github.com/midpeter444/mybatis-koans
https://github.com/carrot-garden/sql_mybatis-koans

students of koans will run something like
https://github.com/carrot-garden/sql_mybatis-koans/blob/master/build/maven-run-test-koans.ant

which uses your plugin start/stop;
since students make errors, maven invocations will fail;
students will end up with multiple H2 instances and utter confusion :-)