Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importance of weight_norm #42

Open
faroit opened this issue Jan 24, 2020 · 1 comment
Open

Importance of weight_norm #42

faroit opened this issue Jan 24, 2020 · 1 comment

Comments

@faroit
Copy link

faroit commented Jan 24, 2020

I am looking for LSTM replacement that can easily be deployed with ONNX. As there are many issues with LSTMS in onnx, I was thinking about using TCNs. Now, it turned out that the pytorch onnx export module cannot find a suitable op for the weight_norm operation. My questions is

  • how important is this to the model?
  • can it be safely removed or replaced with a small loss in performance?
@faroit
Copy link
Author

faroit commented Jan 24, 2020

maybe i was mistakenly thing the onnx error message was about the weight_norm. After looking into #14 it might be totally unrelated.

@fuzic does your branch work fine when exported to onnx? which opset did you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faroit