Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_is_unit_test/2 will now correctly set options. #20

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

stassa
Copy link
Collaborator

@stassa stassa commented Dec 26, 2024

  • Previously, set_is_unit_test/2 would only process the argument 'false' and leave options it sets unchanged. This was mainly a problem on windows where the option 'load' was left to 'show', causing the entire Metta $corelib to be echoed to the terminal while loading it to memory. The present commit fixes that.
  • Part of oingoing work to address #227.

* Previously, set_is_unit_test/2 would only process the argument 'false'
  and leave options it sets unchanged. This was mainly a problem on
  windows where the option 'load' was left to 'show', causing the entire
  Metta $corelib to be echoed to the terminal while loading it to
  memory. The present commit fixes that.
* Part of oingoing work to address #227.
@stassa
Copy link
Collaborator Author

stassa commented Dec 26, 2024

Slight clarification: the previous version of set_is_unit_test/2 (in metta_interp.pl) would only process the argument "false" when not running unit tests. When running unit tests it would presumably (haven't tested this) also accept "true". The problem is that it would not change any option other than 'test' -by passing it the value of its argument- and so it would leave the option 'load' set to 'show'. That 's what was responsible for dumping the $corelib to the terminal on loading... but only on windows as reported in trueagi-io/metta-wam#227. It is still not clear to me why the behaviour is different on windows and linux (WSL) so more work is needed but this begins to address #227.

@TeamSPoon TeamSPoon merged commit 87ea324 into logicmoo:master Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants