Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape_backslashes should be used unconditionally #53

Open
Artoria2e5 opened this issue Sep 23, 2021 · 0 comments
Open

escape_backslashes should be used unconditionally #53

Artoria2e5 opened this issue Sep 23, 2021 · 0 comments

Comments

@Artoria2e5
Copy link

We currently have

gpp/src/gpp.c

Lines 3137 to 3141 in 8e6fe69

#ifdef WIN_NT
escape_backslashes(filename,&escapedfilename);
#else
escapedfilename = filename;
#endif
with the justification

gpp/src/gpp.c

Lines 3147 to 3149 in 8e6fe69

/* Under windows, files can have backslashes in them.
These should be escaped.
*/
.

Other platforms (mainly Unix-like) can have backslashes in the filename too -- they may even be more liberal at that and allow newlines and other fun stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant