Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action config uses the old ubuntu-18.04 #592

Closed
5 tasks done
aleksanderbl29 opened this issue Sep 12, 2024 · 4 comments
Closed
5 tasks done

Github Action config uses the old ubuntu-18.04 #592

aleksanderbl29 opened this issue Sep 12, 2024 · 4 comments

Comments

@aleksanderbl29
Copy link
Contributor

Before filing a bug

  • I have installed the latest dev version of {precommit} with remotes::install_github('lorenzwalthert/precommit')
  • I have installed the latest hook revisions (update with precommit::autoupdate())
  • I have installed the latest release of the upstream Python framework pre-comit as described under the update instructions.

Describe the bug
When running precommit::use_precommit(ci = "gha") the Github Actions config that is added to the repo is configured to the old 18.04 image of Ubuntu. In my view it should be either ubuntu-latest or ubuntu-22.04.

To Reproduce
Steps to reproduce the behavior:

  1. Run precommit::use_precommit(ci = "gha").
  2. Commit to github repo with Actions enabled.
  3. ERROR: The action stays in a queued state because of the os-image.

Expected behavior
I expect the Github Actions to start by itself when running the steps above.

Additional context
I have tested in my own repo that it works when using ubuntu-latest and ubuntu-22.04.

  • My operating system is: MacOS Sonoma 14.6.1
  • My project uses {renv}.
  • the output of packageVersion('renv')
packageVersion("renv")
#> [1] '1.0.7'
@aleksanderbl29
Copy link
Contributor Author

I have added the PR #593 for you convenience.

@lorenzwalthert
Copy link
Owner

Great, thanks. Maybe we should even default to ubuntu-latest.

@aleksanderbl29
Copy link
Contributor Author

I agree. This eliminates the need for any maintenance on that front.

@aleksanderbl29
Copy link
Contributor Author

As the PR #593 has been merged with the fix, i am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants