Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow source installation again #594

Open
lorenzwalthert opened this issue Sep 15, 2024 · 0 comments
Open

Allow source installation again #594

lorenzwalthert opened this issue Sep 15, 2024 · 0 comments

Comments

@lorenzwalthert
Copy link
Owner

Is your feature request related to a problem? Please describe.

Currently, only binary packages from PPM are supported for additional_dependencies. I would like to laxen the requirements upstream to allow attempting source installations. This was previously disabled, since in case the CRAN mirror has a younger version of the R package you want to depend on than your .pre-commit-config.yaml, you will try to install a source package, as only the up-to-date binary is kept in PPM. Since we use frozen snapshots, we will still be able to install a not-up-to-date binary, since for that URL, there won't ever be another one.
Describe the solution you'd like

With the frozen URLs, I think we can allow source installations again, which should only affect packages that don't have a binary version: They now fail to install, in the future, a source installation should be attempted. In managed environments like pre-commit.ci, this might not work, but at least it will work locally and in CI environments the user controls.

Describe alternatives you've considered

Not use packages as dependencies that don't have a binary on PPM for all required operating systems. Request a binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant