You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
annotation 체크하는 부분을 따로 함수로 빼고, 변수들은 따로 struct로 묶어서 해당 함수에서 struct 값을 업데이트한 다음,
다른 곳에서도 변수 대신 struct를 사용하도록 하면 코드가 좀 더 깔끔해질 것 같습니다.
===============
When creating a K8s service, there is a part in kube-loxilb that checks the annotation of the service and assigns values to variables.
Extract the annotation checking part into a separate function, group the variables into a separate struct, and update the struct value in the function.
I think the code would be cleaner if we used structs instead of variables in other places as well.
The text was updated successfully, but these errors were encountered:
K8s 서비스 생성시, kube-loxilb에서 서비스의 annotation을 체크하고 변수에 값을 할당하는 부분이 있습니다. 다음과 같은 부분입니다.
kube-loxilb/pkg/agent/manager/loadbalancer/loadbalancer.go
Lines 374 to 406 in 6319932
annotation 체크하는 부분을 따로 함수로 빼고, 변수들은 따로 struct로 묶어서 해당 함수에서 struct 값을 업데이트한 다음,
다른 곳에서도 변수 대신 struct를 사용하도록 하면 코드가 좀 더 깔끔해질 것 같습니다.
===============
When creating a K8s service, there is a part in kube-loxilb that checks the annotation of the service and assigns values to variables.
Extract the annotation checking part into a separate function, group the variables into a separate struct, and update the struct value in the function.
I think the code would be cleaner if we used structs instead of variables in other places as well.
The text was updated successfully, but these errors were encountered: