Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createLucideIcon causes missing key error in React #2654

Open
7 of 30 tasks
hypervisor opened this issue Dec 1, 2024 · 2 comments · May be fixed by #2655
Open
7 of 30 tasks

createLucideIcon causes missing key error in React #2654

hypervisor opened this issue Dec 1, 2024 · 2 comments · May be fixed by #2655
Labels
🐛 bug Something isn't working

Comments

@hypervisor
Copy link

Package

  • lucide
  • lucide-angular
  • lucide-flutter
  • lucide-preact
  • lucide-react
  • lucide-react-native
  • lucide-solid
  • lucide-svelte
  • lucide-vue
  • lucide-vue-next
  • Figma plugin
  • source/main
  • other/not relevant

Version

0.462.0

Can you reproduce this in the latest version?

  • Yes
  • No

Browser

  • Chrome/Chromium
  • Firefox
  • Safari
  • Edge
  • iOS Safari
  • Opera
  • Other/not relevant

Operating system

  • Windows
  • Linux
  • macOS
  • ChromeOS
  • iOS
  • Android
  • Other/not relevant

Description

When using an icon created with createLucideIcon you get an error in your console for missing keys. This is not critical, but really annoying.

Steps to reproduce

  1. Use createLucideIcon to create an icon.
  2. Open console logs

Checklist

  • I have searched if someone has submitted a similar issue before and there weren't any. (Please make sure to also search closed issues, as this issue might already have been resolved.)
@hypervisor hypervisor added the 🐛 bug Something isn't working label Dec 1, 2024
@hypervisor hypervisor linked a pull request Dec 1, 2024 that will close this issue
Open
7 tasks
@ericfennis
Copy link
Member

Hmm, this should not happen, all iconNodes have keys.
Which icon did you imported, or was it a custom icon?

@hypervisor
Copy link
Author

This only happens when creating custom icons. Any custom icon should give the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add unique keys to iconNode and children to resolve React errors hypervisor/lucide
2 participants
@ericfennis @hypervisor