Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSHint changes so tests pass out of the box #8

Open
yeeplusplus opened this issue Apr 27, 2016 · 1 comment
Open

JSHint changes so tests pass out of the box #8

yeeplusplus opened this issue Apr 27, 2016 · 1 comment

Comments

@yeeplusplus
Copy link

On the latest commit (dde5a74), grunt jshint:source fails.

Some of these failures are violations of rules that have been deprecated in favor of using JSCS / ESLint. In order to ease the developer on-boarding process, I think it makes sense to relax these rules, where appropriate, so that the project does not spew a bunch of errors the first time the tests are run. This can be done by upgrading grunt-contrib-jshint to 1.0.0, which removes the deprecated JSHint options.

Other failures are straightforward (== instead of ===, missing semicolons, etc.).

I'm happy to make a PR. Is this type of change desired by the community here?

@arijitdasgupta
Copy link

@yeeplusplus A PR is most welcome.

You could also use the -f flag to ignore the JSHint warnings for now. :-)

Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants