You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the latest commit (dde5a74), grunt jshint:source fails.
Some of these failures are violations of rules that have been deprecated in favor of using JSCS / ESLint. In order to ease the developer on-boarding process, I think it makes sense to relax these rules, where appropriate, so that the project does not spew a bunch of errors the first time the tests are run. This can be done by upgrading grunt-contrib-jshint to 1.0.0, which removes the deprecated JSHint options.
Other failures are straightforward (== instead of ===, missing semicolons, etc.).
I'm happy to make a PR. Is this type of change desired by the community here?
The text was updated successfully, but these errors were encountered:
On the latest commit (dde5a74),
grunt jshint:source
fails.Some of these failures are violations of rules that have been deprecated in favor of using JSCS / ESLint. In order to ease the developer on-boarding process, I think it makes sense to relax these rules, where appropriate, so that the project does not spew a bunch of errors the first time the tests are run. This can be done by upgrading grunt-contrib-jshint to 1.0.0, which removes the deprecated JSHint options.
Other failures are straightforward (== instead of ===, missing semicolons, etc.).
I'm happy to make a PR. Is this type of change desired by the community here?
The text was updated successfully, but these errors were encountered: