Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link generator does not support non-ascii characters. #36

Open
brecert opened this issue Sep 6, 2020 · 0 comments
Open

link generator does not support non-ascii characters. #36

brecert opened this issue Sep 6, 2020 · 0 comments

Comments

@brecert
Copy link

brecert commented Sep 6, 2020 •
edited
Loading

This issue is related to #21.

When inserting a Unicode character such as ✨, the app will throw String contains an invalid character.
This happens due to btoa not supporting any unicode characters outside of the ascii range.

https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa
brecert added a commit to brecert/perflink that referenced this issue Sep 6, 2020
@brecert
Support non-ascii Unicode characters (lukejacksonn#36, lukejacksonn#21)
2dd738c 
Fixes "reversed" process for encode/decoding, this should not affect any previously saved links (due to them failing if there was a Unicode character)
@brecert brecert mentioned this issue Sep 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support non-ascii Unicode characters (#36, #21) brecert/perflink
1 participant
@brecert