(Solved) Broken opusfile-git

[slyfox1186]

Broken opusfile-git

https://0x0.st/s3YC.zip

[LigH-de]

Brief excerpt from ab-suite.make.log (to include searchable keywords in this report):

  CC       src/libopusurl_la-wincerts.lo
../src/wincerts.c: In function 'op_capi_new':
../src/wincerts.c:42:8: error: dereferencing pointer to incomplete type 'X509_LOOKUP {aka struct x509_lookup_st}'
     _lu->method_data=(char *)h_store;
        ^~
../src/wincerts.c: In function 'op_capi_retrieve_by_subject':
../src/wincerts.c:61:3: warning: implicit declaration of function 'CRYPTO_w_lock'; did you mean 'CRYPTO_zalloc'? [-Wimplicit-function-declaration]
   CRYPTO_w_lock(CRYPTO_LOCK_X509_STORE);
   ^~~~~~~~~~~~~
   CRYPTO_zalloc
../src/wincerts.c:61:17: error: 'CRYPTO_LOCK_X509_STORE' undeclared (first use in this function); did you mean 'CRYPTO_EX_INDEX_X509_STORE'?
   CRYPTO_w_lock(CRYPTO_LOCK_X509_STORE);
                 ^~~~~~~~~~~~~~~~~~~~~~
                 CRYPTO_EX_INDEX_X509_STORE
../src/wincerts.c:61:17: note: each undeclared identifier is reported only once for each function it appears in
../src/wincerts.c:63:3: warning: implicit declaration of function 'CRYPTO_w_unlock'; did you mean 'CRYPTO_realloc'? [-Wimplicit-function-declaration]
   CRYPTO_w_unlock(CRYPTO_LOCK_X509_STORE);
   ^~~~~~~~~~~~~~~
   CRYPTO_realloc

Apparently incompatible with OpenSSL 1.1 – may be advisable to remove support for HTTP(S) URL's.

[slyfox1186]

edit file:
media-suite_compile.sh

For a fresh compile not yet run replace lines 594-604 with

if [[ $standalone = y ]] && enabled libopus; then
do_pacman_install openssl libogg
hide_libressl
_check=(opus/opusfile.h libopus{file,url}.{,l}a opus{file,url}.pc)
_deps=(opus.pc "$MINGW_PREFIX"/lib/pkgconfig/{libssl,ogg}.pc)
if do_vcs "https://github.com/xiph/opusfile.git"; then
do_uninstall "${_check[@]}"
do_autogen
do_separate_confmakeinstall --disable-{http,examples,doc}
do_checkIfExist
fi

The following lines are ultimately what I did to solve my specific build. Line numbers may vary.

Search for this line to find your place.

https://github.com/xiph/opusfile.git

replace line 559 with

do_separate_confmakeinstall --disable-{http,examples,doc}

replace line 568 with

do_separate_confmakeinstall --disable-{http,examples,doc}

[LigH-de]

Should be lines 602 and 611 in the latest version.

Creating patch and pull request...

[wiiaboo]

Removing http seems like a big feature loss.

[LigH-de]

At least it can be reverted easily when it works again.

Alternative? ... Force a dependency to a lower but supported OpenSSL version until a newer version is supported?

And - damn, I wanted to test this patch before submitting it, but the next (unrelated) issue breaks it.

[wiiaboo]

Workaround in f77cb0b.

[wiiaboo]

Was checking why only mingw was affected since opusfile is working fine in Archlinux, but it's because of windows-specific code to get certificates.