gnome extension: bug on archlinux arm when locking screen/suspend

[lidstah]

Hi,

Using your debian rootfs kernel and dtb files but with archlinux arm userland - per Dorian tutorial - and Gnome 43, when suspending or locking screen, the gnome extension menu is reduced to "rotate screen", and Gnome's extension manager reports an error. Not sure if this behavior is identical on debian bookworm, but a simple fix in my case was, in the file extension.js, function disable() lines, to modify it like this:

    disable() {
        log(`disabling ${Me.metadata.name}`);

        this._m_warm_backlight_slider.destroy();
        this._m_warm_backlight_slider = null;
        this._indicator.destroy();
        this._indicator = null;
    }

Thus destroying sliders before destroying the indicator, which seems to correct the problem encountered in my case,

Please excuse my bad english, and excuse me if I break any rule. feel free to delete this post if it is the case.

By the way, thanks a lot for the work you and the pinenote community put in making this awesome little piece of hardware working nicely with GNU/Linux, which I'm typing this issue from.

Best regards,

[m-weigand]

Hi there!

Thank you very much for reporting this. It may be some time, but I will look into this. Looking forward to any additional bug reports or suggestions that you have.

Best regards

Maximilian

[lidstah]

You're welcome! I checked again with the original extension.js file and I made a mistake while reporting the problem. With the original disable() function, if I lock screen, the gnome extension seems to crash as the widget and menu disappear from gnome shell's top bar. One of my first test was to comment these two lines:

        this._m_warm_backlight_slider.destroy();
        this._m_warm_backlight_slider = null;

but then, the extension's menu was only showing the Rotate option - which seems logical as the slider wasnt properly destroyed upon exit. Which led me to the conclusion that it should - maybe - be destroyed before the indicator destruction. As my gnome and JS knowledge is far from great, there's probably a way better solution to this little problem.

Once again, thanks alot for all the work you and the pinenote community do around this little machine. I felt like 20 years younger tinkering with it via the UART dongle, cross-compiling the kernel thanks to your scripts, and using it as my daily driver when on the road :)