Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cell list pair #110

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

New cell list pair #110

wants to merge 39 commits into from

Conversation

lmiq
Copy link
Member

@lmiq lmiq commented Dec 9, 2024

This PR will implement the construction of two cell lists and use projection and partitioning also when two sets are provided, to test performance improvements and potentially fix #108

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (1cd4a1d) to head (4bc6047).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core_computing/auxiliary_functions.jl 88.23% 4 Missing ⚠️
src/CellLists.jl 90.32% 3 Missing ⚠️
src/core_computing/cross.jl 98.59% 2 Missing ⚠️
src/core_computing/self.jl 98.63% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   91.14%   96.28%   +5.13%     
==========================================
  Files           9       12       +3     
  Lines        1209     1265      +56     
==========================================
+ Hits         1102     1218     +116     
+ Misses        107       47      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmiq lmiq mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad scaling when 2 sets of particles are used.
1 participant