-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to add a className prop #247
Comments
I subscribe to this! I would love to be able to add classNames to the json viewer object. When i do this:
The component overrides it and shows only rect-json-viewer. I could manually set each style element but my target here is to have the same style as rs-input elements, included hover and other actions css. Being able to do something like: I could try to do a PR regarding this issue if you're ok to add a new prop! |
Quick win for those wondering:
Does the trick |
Will this be considered? It should be a minimal requirement to have. Thanks |
Resolves mac-s-g#247
Since this repository is dead, I looked at the fork suggested by 443465e Looks like I cannot create issues in that fork. @Kikobeats, I'm tagging you since you seem to be one of the maintainers of https://github.com/microlinkhq/react-json-view. Two questions for you:
On another note, there is another fork that seems more receptive to feedback as it does allow reporting of issues (https://github.com/TexteaInc/json-viewer), although not sure how much divergence with the officially recommended fork. cc @pionxzh, if you care to elaborate. Update: I was going through some issues and came across himself65/rich-data#10. Not exactly sure what is going on there, but from first glance it seems best to avoid https://github.com/TexteaInc/json-viewer to avoid trouble. |
Thanks for mentioning our repo. I can provide some insights:
Thank you for your understanding. 🙏 |
A lot of times, we've predefined classes that we want to use with this, need ability to pass that as prop. Thanks!
The text was updated successfully, but these errors were encountered: