-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .co.uk and uk.com domains #549
Comments
This is an interesting topic for a couple of reasons:
Open to suggestions on how to identify the first elegantly and then potentially flag as a warning for the second. |
Since the admin can't do much here to fix TLDs it might be best to avoid showing this as failed. We could still list them in the table here and flag as ignored. I think we can hard-code the domains in the PowerShell cmdlet and folks can submit PRs to add them. We should also add support to pass in domains to be ignore for this test. When we add support for configuring parameters (hopefully this quarter), admins will be able to exclude other domains. Thoughts @soulemike? |
This sounds like a reasonable approach. Only use the domains explicitly registered with Entra for the pass/fail, then show the results for the hierarchy but as ignored for the overall result.
Yep, allowing an ignored domains array as a property makes sense as well. I can work on wireframing these two changes up. |
These are both tLDs and should not be tested for SPF, DMARC, etc.
The text was updated successfully, but these errors were encountered: