Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid manipulating users VirtualService and Gateway #892

Open
aslakknutsen opened this issue Sep 9, 2021 · 0 comments
Open

Avoid manipulating users VirtualService and Gateway #892

aslakknutsen opened this issue Sep 9, 2021 · 0 comments
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement

Comments

@aslakknutsen
Copy link
Member

What can be improved

Given that we only want to support host based routing, aka require to use the exposed hostname to access the route, we should be able to get away with not modifying any of the user resources.

We already create a VirtualService bound to the exposed host name to add the header property, and we should be able to have multiple gateways with different hosts, we might get away with not manipulating the users VirtualService, but rather both add headers and match headers in our own VirtualService. Investigate.

Why

Generally speaking we should avoid touching the users configured resources.

@aslakknutsen aslakknutsen added kind/enhancement Kind: New feature or improvement component/operator Component: Operator service labels Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant