Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show 'Running' window until Board.onReady #6

Open
makenai opened this issue Jan 22, 2015 · 2 comments
Open

Don't show 'Running' window until Board.onReady #6

makenai opened this issue Jan 22, 2015 · 2 comments
Labels

Comments

@makenai
Copy link
Owner

makenai commented Jan 22, 2015

Right now we just show 'Running' when they hit run. The process could actually have failed horribly in the background. Let's get better communication going.

@makenai makenai added the bug label Jan 22, 2015
@makenai
Copy link
Owner Author

makenai commented Jan 22, 2015

Double checked. This is a hack:

$('#execute').on('click', function(e) {
e.preventDefault();
setTimeout(function() {
RunningWindow.show();
}, 1000);
if ( $('#code-tab').parent().is('.active') ) {
sendMessage( 'code', editor.getValue() );
} else {
sendMessage( 'code', generateCode() );
}
});

@ajfisher
Copy link
Contributor

This is now complete and merged in as part of #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants